[MRG] Remove openmp implementation for emd2 #820
Merged
Merged
Conversation
… runtime gains observed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #820 +/- ##
==========================================
- Coverage 96.81% 96.79% -0.02%
==========================================
Files 124 124
Lines 24263 24276 +13
==========================================
+ Hits 23490 23498 +8
- Misses 773 778 +5 🚀 New features to boost your workflow:
|
rflamary
changed the title
rflamary
reviewed
Jun 15, 2026
rflamary
left a comment
rflamary
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @nathanneike
a few comments below about a warning to telle user about deprecation
| "max" selects the highest number possible. | ||
| numThreads: int or "max", optional (default=1) | ||
| Deprecated compatibility parameter. The network simplex solver no | ||
| longer uses OpenMP, so this parameter is ignored. |
Collaborator
There was a problem hiding this comment.
please add a test and a warning in the function to nstate that numThreads is deprecated if not given the default value. do that for both emd and emd2 please
|
|
||
| def test_omp_emd2(): | ||
| # test emd2 and emd2 with openmp for simple identity | ||
| def test_emd2_num_threads_compatibility(): |
Collaborator
There was a problem hiding this comment.
and check that a warning is raised
6 tasks
rflamary
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Motivation and context / Related issue
Remove the OpenMP-specific network simplex implementation because it did not provide meaningful runtime
gains, while keeping
numThreadsas a compatibility parameter.How has this been tested (if it applies)
Updated the existing EMD/EMD2 test coverage to check that
numThreadsremains accepted as a no-opcompatibility parameter.
PR checklist